[RFC WIP] feat(typeorm): add a component for TypeORM integration#4794
Closed
raymondfeng wants to merge 1 commit into
Closed
[RFC WIP] feat(typeorm): add a component for TypeORM integration#4794raymondfeng wants to merge 1 commit into
raymondfeng wants to merge 1 commit into
Conversation
raymondfeng
changed the title
raymondfeng
changed the title
raymondfeng
force-pushed
the
typeorm
branch
2 times, most recently
from
March 9, 2020 20:36
fe0c012 to
9cd6f79
Compare
raymondfeng
marked this pull request as ready for review
March 27, 2020 17:25
Contributor
Author
|
Some prior effort - #763 |
This was referenced Apr 19, 2020
raymondfeng
force-pushed
the
typeorm
branch
3 times, most recently
from
April 26, 2020 16:20
0a41ca4 to
30da41c
Compare
Member
|
@raymondfeng @hacksparrow Can we close this in favor of #5801 now? |
Contributor
|
We can close it, IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PoC to illustrate possible shadow integration with TypeORM:
@typeorm.connectionto provide injection of TypeORM connections - can be extended to allow repository...Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈